Repository navigation
fix(deps): require doctrine-bundle 1.0.5 so purges skip WordPress tables - #7
Merged
Merged
Conversation
doctrine-bundle 1.0.5 hides WordPress tables from every DBAL schema filter. The fixtures purger respects that filter, so requiring 1.0.5 guarantees `doctrine:fixtures:load` can no longer truncate `wp_*` tables in a shared database. The filter fails closed when it cannot determine the WordPress table prefix, so the test suite, which runs without WordPress, now sets DB_TABLE_PREFIX.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
doctrine-bundle 1.0.5 added a schema filter that hides all WordPress tables from Doctrine schema tools; without it, schema updates and migration diffs dropped
wp_*tables. This bundle's purger respects the same filter, but still allowed doctrine-bundle 1.0.3/1.0.4, and its test suite fails against 1.0.5 because the filter fails closed when no WordPress table prefix is known.Fix
sympress/doctrine-bundle ^1.0.5(lock updated, only that package changes).DB_TABLE_PREFIX=wp_inphpunit.xml.dist, the same way doctrine-bundle's own suite does.Tests
composer validate --strictvalid,composer qagreen, PHPUnit 18/18. Before this change, 3 integration tests errored against doctrine-bundle 1.0.5.Release: 1.1.1 (patch).